feat(notifications): direct BRD + Plane links in approve ping (ORCH-017) #37

Merged
admin merged 12 commits from feature/ORCH-017-brd-plane-telegram into main 2026-06-05 22:45:12 +03:00

12 Commits

Author SHA1 Message Date
stream
43ef160f40 docs(ORCH-017): drop check_tests_passed/result gate notes (belong to ORCH-47); keep only approve-ping link docs
All checks were successful
CI / test (push) Successful in 12s
CI / test (pull_request) Successful in 12s
2026-06-05 19:35:28 +00:00
9c28431167 reviewer(ET): auto-commit from reviewer run_id=124
All checks were successful
CI / test (push) Successful in 15s
CI / test (pull_request) Successful in 13s
2026-06-05 19:32:33 +00:00
stream
d615747d53 revert(ORCH-017): drop shared check_tests_passed gate change — moved to ORCH-47 (own ADR); keep only approve-ping links
All checks were successful
CI / test (push) Successful in 12s
CI / test (pull_request) Successful in 11s
2026-06-05 19:28:27 +00:00
c91eb7f82b reviewer(ET): auto-commit from reviewer run_id=123
All checks were successful
CI / test (push) Successful in 12s
CI / test (pull_request) Successful in 12s
2026-06-05 18:40:52 +00:00
e62d51aa77 fix(qg): testing gate reads documented tester result: frontmatter key (ORCH-017)
All checks were successful
CI / test (push) Successful in 12s
CI / test (pull_request) Successful in 11s
check_tests_passed/_parse_tests_verdict gated the testing -> deploy-staging
transition on `verdict:`/`status:` in 13-test-report.md, but the tester agent
prompt (.openclaw/agents/tester*) documents `result: PASS | FAIL` as THE
machine-readable field. A report that followed the contract literally
(ORCH-017: only `result: PASS`, no verdict:/status:) was bounced back to
development with a misleading "Tests FAILED". ORCH-016 only passed because its
report redundantly carried both `verdict:` and `result:`.

Treat `result:` as a first-class machine field alongside verdict/status; a
negative token in any field stays authoritative (ET-013 contract preserved).
Self-hosting QG fix: unblocks every project whose tester emits only `result:`.

Docs updated in-PR: CHANGELOG, architecture README machine-keys note.
Tests: test_qg.py::TestCheckTestsPassed::test_result_pass_only_passes / _fail_only_fails.

Refs: ORCH-017
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-06-05 18:34:25 +00:00
0e999d289d reviewer(ET): auto-commit from reviewer run_id=120
All checks were successful
CI / test (push) Successful in 12s
CI / test (pull_request) Successful in 11s
2026-06-05 18:25:02 +00:00
950a86e4d8 tester(ET): auto-commit from tester run_id=118
All checks were successful
CI / test (push) Successful in 12s
CI / test (pull_request) Successful in 17s
2026-06-05 18:20:16 +00:00
6509891f74 reviewer(ET): auto-commit from reviewer run_id=117
All checks were successful
CI / test (push) Successful in 13s
CI / test (pull_request) Successful in 11s
2026-06-05 18:18:42 +00:00
69a4aaab99 feat(notifications): direct BRD + Plane links in approve ping (ORCH-017)
All checks were successful
CI / test (push) Successful in 12s
CI / test (pull_request) Successful in 12s
notify_approve_requested now embeds two HTML <a> links into the single
notifying approve-gate message: a Gitea branch-view link to 01-brd.md and a
Plane issue browser link. Adds ORCH_PLANE_WEB_URL (external Plane web URL,
fallback to plane_api_url) with a loopback-guard that omits the Plane link
when the resolved base is localhost/empty (no broken localhost URLs in prod).

Each link is built independently and omitted on missing data; the message and
the "flip to Approved" call to action are always sent as exactly one ping. The
shared send_telegram helper is left untouched (min blast radius for the
self-hosting prod container). Dynamic labels are html.escaped; parse_mode=HTML
preserved. QG registry / stages / approve handler unchanged.

Docs updated in-PR: CHANGELOG, .env.example, INFRA env map.
Tests: test_notify_approve_links.py, test_analysis_approve_flow_links.py.

Refs: ORCH-017
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-06-05 17:58:00 +00:00
c9b1195c0b architect(ET): auto-commit from architect run_id=115
All checks were successful
CI / test (push) Successful in 12s
2026-06-05 17:50:28 +00:00
08528b655e analyst(ET): auto-commit from analyst run_id=112
All checks were successful
CI / test (push) Successful in 12s
2026-06-05 17:39:34 +00:00
7f31d62a4d docs: init ORCH-017 business request
All checks were successful
CI / test (push) Successful in 13s
2026-06-05 19:59:55 +03:00