fix(tests): per-project Plane states in webhook tests + close CI hole (ORCH-39) #35

admin · 2026-06-05T16:49:49+03:00

admin commented

2026-06-05 16:49:49 +03:00

ORCH-39

Fixes 4 webhook tests that lagged behind ORCH-10 (per-project Plane state resolution) and closes a CI hole.

Tests

test_m6_sequence.py + test_plane_webhook.py mocked get_project_states with a deterministic per-project ET/ORCH state map (no network) and reset _STATES_CACHE per test; each request now sends the in_progress UUID matching its own project.

CI hole

requirements.txt lacked pytest-asyncio -> 6 @pytest.mark.asyncio tests in test_orch10_states.py were SILENTLY SKIPPED (green CI, async paths never ran). Added pytest-asyncio + pytest.ini (asyncio_mode=auto, strict markers) and hardened ci.yml (set -euo pipefail, --strict-markers).

Verification

pytest tests/ -q in prod orchestrator image from the branch clone: 342 passed, 0 skipped, 0 failed.

src/ unchanged. Do NOT merge — reviewer merges after check.

## ORCH-39 Fixes 4 webhook tests that lagged behind ORCH-10 (per-project Plane state resolution) and closes a CI hole. ### Tests - test_m6_sequence.py + test_plane_webhook.py mocked get_project_states with a deterministic per-project ET/ORCH state map (no network) and reset _STATES_CACHE per test; each request now sends the in_progress UUID matching its own project. ### CI hole - requirements.txt lacked pytest-asyncio -> 6 @pytest.mark.asyncio tests in test_orch10_states.py were SILENTLY SKIPPED (green CI, async paths never ran). Added pytest-asyncio + pytest.ini (asyncio_mode=auto, strict markers) and hardened ci.yml (set -euo pipefail, --strict-markers). ### Verification `pytest tests/ -q` in prod orchestrator image from the branch clone: **342 passed, 0 skipped, 0 failed**. src/ unchanged. Do NOT merge — reviewer merges after check.

admin added 1 commit 2026-06-05 16:49:49 +03:00

fix(tests): per-project Plane states in webhook tests + close CI hole (ORCH-39)

CI / test (push) Successful in 11s

Details

CI / test (pull_request) Successful in 10s

Details

5f93cba297

After ORCH-10 the webhook resolves Plane state UUIDs per-project via
get_project_states(project_id). The m6/plane webhook tests hardcoded the
enduro in_progress UUID for ORCH-project payloads, so the pipeline never
started and task creation assertions failed.

Tests:
- Mock get_project_states with a deterministic per-project ET/ORCH map (no
  network) and reset _STATES_CACHE via reload_project_states() per test.
- Send each request with the in_progress UUID that matches its own project.

CI hole:
- requirements.txt lacked pytest-asyncio, so the 6 @pytest.mark.asyncio tests
  in test_orch10_states.py were SILENTLY SKIPPED -> CI green while async paths
  never ran. Add pytest-asyncio + pytest.ini (asyncio_mode=auto, strict
  markers); harden ci.yml (set -euo pipefail, --strict-markers) so any failure
  or unknown marker reds the build and the whole suite runs.

src/ unchanged (per-project resolving is the ORCH-10 feature, kept as-is).

admin merged commit f375be249f into main

2026-06-05 17:36:40 +03:00

admin referenced this issue from a commit

2026-06-05 17:36:42 +03:00

fix(tests): per-project Plane states in webhook tests + close CI hole (ORCH-39) (#35)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: admin/orchestrator#35