revert(ORCH-017): drop shared check_tests_passed gate change — moved to ORCH-47 (own ADR); keep only approve-ping links
This commit is contained in:
@@ -216,29 +216,6 @@ class TestCheckTestsPassed:
|
||||
passed, reason = check_tests_passed("enduro-trails", "ET-001")
|
||||
assert passed is True
|
||||
|
||||
def test_result_pass_only_passes(self, setup_work_item_dir):
|
||||
# ORCH-017: the tester agent prompt documents `result: PASS | FAIL` as the
|
||||
# machine-readable field. A report that follows that contract literally
|
||||
# (only `result: PASS`, no verdict:/status:) MUST pass the gate. Before this
|
||||
# fix the gate ignored `result:` and bounced such reports to development.
|
||||
self._write(
|
||||
setup_work_item_dir,
|
||||
"---\ntype: test-report\nwork_item_id: ET-001\nresult: PASS\n---\n\nbody\n",
|
||||
)
|
||||
passed, reason = check_tests_passed("enduro-trails", "ET-001")
|
||||
assert passed is True
|
||||
assert "PASS" in reason
|
||||
|
||||
def test_result_fail_only_fails(self, setup_work_item_dir):
|
||||
# The negative side of the documented `result: PASS | FAIL` contract.
|
||||
self._write(
|
||||
setup_work_item_dir,
|
||||
"---\ntype: test-report\nresult: FAIL\n---\n\n23 passed in body\n",
|
||||
)
|
||||
passed, reason = check_tests_passed("enduro-trails", "ET-001")
|
||||
assert passed is False
|
||||
assert "FAIL" in reason.upper()
|
||||
|
||||
def test_blocked_verdict_with_pass_in_body_fails(self, setup_work_item_dir):
|
||||
# THE ET-013 BUG: verdict BLOCKED but body is full of "PASS"/"passed".
|
||||
self._write(
|
||||
|
||||
Reference in New Issue
Block a user