feat(notifications): direct BRD + Plane links in approve ping (ORCH-017)

notify_approve_requested now embeds two HTML <a> links into the single
notifying approve-gate message: a Gitea branch-view link to 01-brd.md and a
Plane issue browser link. Adds ORCH_PLANE_WEB_URL (external Plane web URL,
fallback to plane_api_url) with a loopback-guard that omits the Plane link
when the resolved base is localhost/empty (no broken localhost URLs in prod).

Each link is built independently and omitted on missing data; the message and
the "flip to Approved" call to action are always sent as exactly one ping. The
shared send_telegram helper is left untouched (min blast radius for the
self-hosting prod container). Dynamic labels are html.escaped; parse_mode=HTML
preserved. QG registry / stages / approve handler unchanged.

Docs updated in-PR: CHANGELOG, .env.example, INFRA env map.
Tests: test_notify_approve_links.py, test_analysis_approve_flow_links.py.

Refs: ORCH-017
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

src/config.py

@@ -4,6 +4,11 @@ from pydantic_settings import BaseSettings
 class Settings(BaseSettings):
     # Plane
     plane_api_url: str = "http://localhost:8091"
+    # ORCH-017: external (browser) web URL of Plane for clickable issue links in
+    # notifications, e.g. https://plane.example.org. Falls back to plane_api_url,
+    # but a loopback fallback (localhost/127.0.0.1) is treated as "no web URL" and
+    # the Plane link is omitted (see notifications._build_plane_issue_link).
+    plane_web_url: str = ""
     plane_api_token: str = ""
     plane_workspace_slug: str = ""
     plane_webhook_secret: str = ""

src/notifications.py

@@ -544,6 +544,105 @@ def notify_qg_failure(task_id: int, stage: str, check: str, reason: str):
     logger.warning(f"\u26a0\ufe0f {work_item_id}: QG {check} \u2014 failed: {reason}")
 
 
+# ORCH-017: hosts that are not clickable off the deploy box. A Plane web-base
+# resolving to one of these (the plane_api_url loopback default) means "no usable
+# browser URL" -> the Plane link is omitted rather than emitted broken (ADR-001 Р-3).
+_LOOPBACK_HOSTS = frozenset({"localhost", "127.0.0.1", "0.0.0.0", "::1"})
+
+
+def _is_loopback_base(url: str) -> bool:
+    """True if the URL's host is a loopback/local address (not clickable off-host).
+
+    Empty/garbage URLs count as loopback (i.e. unusable) so callers omit the link.
+    """
+    if not url:
+        return True
+    try:
+        from urllib.parse import urlparse
+        host = (urlparse(url).hostname or "").lower()
+        return (not host) or host in _LOOPBACK_HOSTS
+    except Exception:
+        return True
+
+
+def _get_task_link_fields(task_id: int):
+    """ORCH-017: read (repo, branch, plane_issue_id) for a task. Never raises.
+
+    Returns (None, None, None) on any error / missing row so link building can
+    degrade gracefully (AC-6).
+    """
+    try:
+        from .db import get_db
+        conn = get_db()
+        row = conn.execute(
+            "SELECT repo, branch, plane_issue_id FROM tasks WHERE id=?", (task_id,)
+        ).fetchone()
+        conn.close()
+        if not row:
+            return None, None, None
+        return row["repo"], row["branch"], row["plane_issue_id"]
+    except Exception as e:
+        logger.warning(f"_get_task_link_fields({task_id}) failed: {e}")
+        return None, None, None
+
+
+def _build_brd_link(repo, branch, work_item_id) -> str | None:
+    """ORCH-017: '<a>' to 01-brd.md in Gitea branch-view, or None if data missing.
+
+    Mirrors the canonical branch-view pattern in src/usage.py: base =
+    gitea_public_url or gitea_url, owner = gitea_owner (AC-1/AC-3). The href is
+    html.escaped as defence-in-depth even though parts come from trusted
+    config/DB (AC-7).
+    """
+    s = _get_settings()
+    base = (
+        getattr(s, "gitea_public_url", "") or getattr(s, "gitea_url", "")
+    ).rstrip("/")
+    owner = getattr(s, "gitea_owner", "")
+    if not (base and owner and repo and branch and work_item_id):
+        return None
+    url = (
+        f"{base}/{owner}/{repo}/src/branch/{branch}"
+        f"/docs/work-items/{work_item_id}/01-brd.md"
+    )
+    return (
+        f'<a href="{html.escape(url, quote=True)}">'
+        f"\U0001f4c4 Открыть BRD</a>"
+    )
+
+
+def _build_plane_issue_link(repo, plane_issue_id) -> str | None:
+    """ORCH-017: '<a>' to the Plane issue browser page, or None if unusable.
+
+    Full path per ADR-001 Р-2:
+    ``{web_base}/{workspace_slug}/projects/{project_id}/issues/{issue_id}/``.
+    web_base = plane_web_url or plane_api_url (AC-3); a loopback base is treated
+    as "no web URL" and the link is omitted (loopback-guard, AC-2/AC-6).
+    """
+    s = _get_settings()
+    web_base = (
+        getattr(s, "plane_web_url", "") or getattr(s, "plane_api_url", "")
+    ).rstrip("/")
+    workspace = getattr(s, "plane_workspace_slug", "")
+    if not (web_base and workspace and plane_issue_id) or _is_loopback_base(web_base):
+        return None
+    try:
+        from .projects import get_project_by_repo
+        project = get_project_by_repo(repo) if repo else None
+    except Exception:
+        project = None
+    if not project or not getattr(project, "plane_project_id", ""):
+        return None
+    url = (
+        f"{web_base}/{workspace}/projects/{project.plane_project_id}"
+        f"/issues/{plane_issue_id}/"
+    )
+    return (
+        f'<a href="{html.escape(url, quote=True)}">'
+        f"✅ Задача в Plane</a>"
+    )
+
+
 def notify_approve_requested(task_id: int):
     """ALERT (separate, notifying): BRD/TZ/AC ready -> flip Plane to Approved.
 
@@ -557,10 +656,27 @@ def notify_approve_requested(task_id: int):
     except Exception as e:
         logger.warning(f"notify_approve_requested: brd clock start failed: {e}")
     msg = (
-        f"\U0001f4cb {work_item_id}: BRD/\u0422\u0417/AC \u0433\u043e\u0442\u043e\u0432\u044b. "
+        f"\U0001f4cb {html.escape(work_item_id)}: BRD/\u0422\u0417/AC \u0433\u043e\u0442\u043e\u0432\u044b. "
         f"\u041f\u0435\u0440\u0435\u0432\u0435\u0434\u0438\u0442\u0435 \u0437\u0430\u0434\u0430\u0447\u0443 \u0432 \u0441\u0442\u0430\u0442\u0443\u0441 Approved "
         f"\u0432 Plane \u0434\u043b\u044f \u043f\u0440\u043e\u0434\u043e\u043b\u0436\u0435\u043d\u0438\u044f."
     )
+    # ORCH-017: embed direct links to the BRD doc (Gitea) and the Plane issue so
+    # the reviewer can open both straight from the ping. Each link is built
+    # independently and omitted if its data is missing; building is defensive so
+    # it can NEVER break the alert (AC-1/AC-2/AC-6). Still exactly one notifying
+    # message (AC-5); the call to action above is always preserved (AC-4).
+    try:
+        repo, branch, plane_issue_id = _get_task_link_fields(task_id)
+        links = [
+            link for link in (
+                _build_brd_link(repo, branch, work_item_id),
+                _build_plane_issue_link(repo, plane_issue_id),
+            ) if link
+        ]
+        if links:
+            msg = msg + "\n\n" + "\n".join(links)
+    except Exception as e:
+        logger.warning(f"notify_approve_requested({task_id}): link build failed: {e}")
     logger.info(msg)
     update_task_tracker(task_id)
     send_telegram(msg)  # separate, notifying