feat(web): POI visibility checkbox in terrain popup (ET-002) #5

Merged

admin merged 11 commits from feature/ET-002-poi-toggle into main 2026-05-21 19:36:21 +03:00

Conversation 3 Commits 11 Files Changed 30 +2501 -191

admin commented 2026-05-21 18:51:30 +03:00

Owner

Copy Link

Summary

• Adds a «POI» checkbox to the terrain popup toggling the poi-circles / poi-labels layers via map.setLayoutProperty.
• State persisted in localStorage (poi-visible) and restored on load / style change; kept consistent with runtime layerState.poi per ADR-0001.
• Pure client-side change (src/web/index.html, src/web/app.js) — no backend/DB/infra impact.

Tests

• 7 behavioral JS unit tests (TP-01..TP-04 + extras) run via node --test, wrapped by tests/unit/test_poi_toggle.py (9 static structure checks) so they execute under the existing pytest tests/ CI step.
• ruff check src/ ✅ · pytest tests/ ✅ (14 passed, 4 skipped) · docker build ✅

Test plan

• Open terrain popup → «POI» checkbox visible after «Тропы», separated by <hr>
• Uncheck → POI markers disappear; check → reappear
• Reload page → checkbox state and POI visibility preserved
• Toggling other terrain/trails checkboxes unaffected

Notes

• e2e scenarios TP-05..TP-09 need Playwright infra absent from the repo (new npm packages forbidden by 07-infra-requirements.md); their behavioral core is covered by the JS unit tests + static checks.

Refs: ET-002

## Summary - Adds a «POI» checkbox to the terrain popup toggling the `poi-circles` / `poi-labels` layers via `map.setLayoutProperty`. - State persisted in `localStorage` (`poi-visible`) and restored on load / style change; kept consistent with runtime `layerState.poi` per ADR-0001. - Pure client-side change (`src/web/index.html`, `src/web/app.js`) — no backend/DB/infra impact. ## Tests - 7 behavioral JS unit tests (TP-01..TP-04 + extras) run via `node --test`, wrapped by `tests/unit/test_poi_toggle.py` (9 static structure checks) so they execute under the existing `pytest tests/` CI step. - `ruff check src/` ✅ · `pytest tests/` ✅ (14 passed, 4 skipped) · `docker build` ✅ ## Test plan - [ ] Open terrain popup → «POI» checkbox visible after «Тропы», separated by `<hr>` - [ ] Uncheck → POI markers disappear; check → reappear - [ ] Reload page → checkbox state and POI visibility preserved - [ ] Toggling other terrain/trails checkboxes unaffected ## Notes - e2e scenarios TP-05..TP-09 need Playwright infra absent from the repo (new npm packages forbidden by `07-infra-requirements.md`); their behavioral core is covered by the JS unit tests + static checks. Refs: ET-002

admin added 8 commits 2026-05-21 18:51:30 +03:00

fix: restore UI to phase 5.4 (terrain, scale bar, zoom controls) 8d36f38be6

Merge PR #4: restore UI phase 5.4 + ET-001 fdc9836690

fix: switchMapStyle loads style as JSON with absolute tile URLs ... f561c3bd41

Fixes trails/tracks not rendering after theme switch.
The issue was that map.setStyle(url) caused MapLibre to resolve
relative tile paths without /enduro/ prefix, resulting in 404s.

docs: restructure phases — per-phase BRD, remove monolithic pilot BRD 832099c3c6

docs(ET-002): BRD, ТЗ, AC, Test Plan — чекбокс POI в попапе рельефа f1f4d5f336

docs(ET-002): status → approved 73c9dc46a0

docs(ET-002): add ADR-0001 and infra requirements for POI toggle ... af579f7f2a

Record architecture decision to implement POI visibility toggling
client-side (setLayoutProperty + localStorage), reusing the existing
layerState model, with no backend, DB or infrastructure changes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

feat(web): add POI visibility checkbox to terrain popup ... 8c17a4f508

Adds a «POI» checkbox to the terrain popup that toggles the
poi-circles and poi-labels layers via map.setLayoutProperty. The
choice is persisted in localStorage (key `poi-visible`) and restored
on page load and after style changes, kept consistent with the
runtime layerState.poi per ADR-0001.

Tests: behavioral JS unit tests (TP-01..TP-04) run via `node --test`,
wrapped by tests/unit/test_poi_toggle.py with static structure checks
so they execute under the existing `pytest tests/` CI step.

Refs: ET-002

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

admin added 1 commit 2026-05-21 19:19:44 +03:00

docs(ET-002): code review APPROVED - no P0/P1 findings a4a0aabfc3

claude-bot approved these changes 2026-05-21 19:23:45 +03:00

Dismissed

claude-bot left a comment

Collaborator

Copy Link

Code review APPROVED - no P0/P1 findings. POI checkbox implementation matches TRZ and ADR.

Code review APPROVED - no P0/P1 findings. POI checkbox implementation matches TRZ and ADR.

admin added 1 commit 2026-05-21 19:29:42 +03:00

test(ET-002): test report PASS - all tests green, ready to deploy c36ee9d39e

admin dismissed claude-bot's review 2026-05-21 19:29:42 +03:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

claude-bot approved these changes 2026-05-21 19:31:34 +03:00

Dismissed

claude-bot left a comment

Collaborator

Copy Link

Re-approve after test report commit. All tests PASS, ready to merge.

Re-approve after test report commit. All tests PASS, ready to merge.

admin added 1 commit 2026-05-21 19:33:43 +03:00

Merge branch 'main' into feature/ET-002-poi-toggle 9ffd6f4b7e

claude-bot approved these changes 2026-05-21 19:36:13 +03:00

claude-bot left a comment

Collaborator

Copy Link

Final approve for merge.

Final approve for merge.

admin merged commit b725810404 into main 2026-05-21 19:36:21 +03:00

admin referenced this issue from a commit 2026-05-21 19:36:22 +03:00

Merge pull request 'feat(web): POI visibility checkbox in terrain popup (ET-002)' (#5) from feature/ET-002-poi-toggle into main

Sign in to join this conversation.

Reviewers

No Reviewers

claude-bot

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claude-bot admin

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: admin/enduro-trails#5